[DOC] Add documentation for database downloader setting #210
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
karenzone
reviewed
Dec 29, 2022
There was a problem hiding this comment.
@edmocosta, I left some comments for your consideration. You can decide. :-)
Thanks for adding this helpful info!
|
Hi @karenzone! Thank you very much for reviewing! |
5 tasks
edmocosta
changed the title
karenzone
reviewed
Jan 17, 2023
karenzone
reviewed
Jan 19, 2023
There was a problem hiding this comment.
My github session expired mid-review and blew away some comments/explanations. I hope that no context is lost.
I left some notes about being more clear that the auto-update and database settings are actually set in two different places--the plugin and logstash.yml.
Co-authored-by: Karen Metts <35154725+karenzone@users.noreply.github.com>
kaisecheng
approved these changes
Jan 23, 2023
karenzone
approved these changes
Jan 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issue: #14823